RE: [PATCH v2 2/3] phy: zynqmp: Add dt bindings for ZynqMP PHY.
From: Subbaraya Sundeep Bhatta
Date: Mon Jan 18 2016 - 04:17:18 EST
> -----Original Message-----
> From: Rob Herring [mailto:robh@xxxxxxxxxx]
> Sent: Friday, January 15, 2016 7:40 AM
> To: Subbaraya Sundeep Bhatta
> Cc: kishon@xxxxxx; balbi@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Subbaraya Sundeep
> Subject: Re: [PATCH v2 2/3] phy: zynqmp: Add dt bindings for ZynqMP PHY.
> On Wed, Jan 13, 2016 at 07:43:24PM +0530, Subbaraya Sundeep Bhatta wrote:
> > This patch adds the document describing dt bindings for ZynqMP PHY.
> > ZynqMP SOC has a High Speed Processing System Gigabit Transceiver
> > which provides PHY capabilties to USB, SATA, PCIE, Display Port and
> > Ehernet SGMII controllers.
> > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxx>
> > ---
> > v2:
> > modified to use phy cells as 2.
> > .../devicetree/bindings/phy/phy-zynqmp.txt | 103
> > 1 file changed, 103 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/phy/phy-zynqmp.txt
> > diff --git a/Documentation/devicetree/bindings/phy/phy-zynqmp.txt
> > b/Documentation/devicetree/bindings/phy/phy-zynqmp.txt
> > new file mode 100644
> > index 0000000..975cf21
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/phy-zynqmp.txt
> > @@ -0,0 +1,103 @@
> > +Xilinx ZynqMP PHY binding
> > +
> > +This binding describes a ZynqMP PHY device that is used to control
> > +ZynqMP High Speed Gigabit Transceiver(GT). ZynqMP PS GTR provides
> > +four lanes and are used by USB, SATA, PCIE, Display port and Ethernet
> SGMMI controllers.
Yeah, I will change it.
> > +
> > +Required properties (controller (parent) node):
> > +- compatible : Should be "xlnx,zynqmp-psgtr"
> > +
> > +- reg : Address and length of register sets for each device in
> > + "reg-names"
> > +- reg-names : The names of the register addresses corresponding to the
> > + registers filled in "reg":
> > + - serdes: SERDES block register set
> > + - siou: SIOU block register set
> > + - lpd: Low power domain peripherals reset control
> > + - fpd: Full power domain peripherals reset control
> > +
> > +-xlnx,tx_termination_fix: Include fix for a functional issue in the GT. The TX
> > + termination resistance can be out of spec due to a
> > + bug in the calibration logic. This issue will be fixed
> > + in silicon in future versions.
> > +
> > +Required nodes : A sub-node is required for each lane the controller
> > + provides.
> > +
> > +Required properties (port (child) nodes):
> > +lane0:
> > +- #phy-cells : Should be 2
> > + Cell after port phandle is device type from:
> > + - <PHY_TYPE_PCIE 0>
> > + - <PHY_TYPE_SATA 0>
> > + - <PHY_TYPE_USB3 0>
> > + - <PHY_TYPE_DP 1>
> > + - <PHY_TYPE_SGMII 0>
> What is the 2nd cell for? The phandle doesn't count for the size.
ZynMP SoC has 2 USB controllers, 1 SATA controller with 2 lanes,
1 PCIe controller with 4 lanes, 1 Display port with 2 lanes and
4 SGMII controllers. PHY provides 4 output lanes only for 14(PIPE) inputs
(as mentioned above: 2 + 2 + 4 + 2+ 4 = 14). All the inputs are routed
to PHY output lanes with a Mux (Interconnect matrix). Only some combinations
are valid i.e, one cannot set mux to use USB1 on lane 0 as such. Here second
cell is input number.
<PHY_TYPE_PCIE 0> derives to PCIe's lane 0 input in driver for which lane 0 of
PHY can be used. The valid inputs of each PHY output lane are mentioned here.
> However, I would simplify this to get rid of the sub nodes and set lane in the 1st
> cell and the type in the 2nd cell.
Sorry I did not get you on how to get rid of sub nodes. Could you please explain?