Re: [PATCH 2/2] power: Add support for TI BQ24261 charger

[Andy Shevchenko]

On Tue, Jan 19, 2016 at 3:26 AM, Pallala, Ramakrishna
<ramakrishna.pallala@xxxxxxxxx> wrote:
>> On Thu, Oct 29, 2015 at 6:34 PM, Ramakrishna Pallala
>> <ramakrishna.pallala@xxxxxxxxx> wrote:
>> > Add new charger driver support for TI BQ24261 charger IC.
>> >
>> > TI BQ24261 charger driver relies on extcon notifications to get the
>> > charger cable type and based on that it will set the charging parameters.

>> > +/* BQ24261 registers */
>> > +#define BQ24261_STAT_CTRL0_ADDR                0x00
>> > +#define BQ24261_CTRL_ADDR              0x01
>> > +#define BQ24261_BATT_VOL_CTRL_ADDR     0x02
>> > +#define BQ24261_VENDOR_REV_ADDR                0x03
>> > +#define BQ24261_TERM_FCC_ADDR          0x04
>> > +#define BQ24261_VINDPM_STAT_ADDR       0x05
>> > +#define BQ24261_ST_NTC_MON_ADDR                0x06
>> > +
>> > +#define BQ24261_RESET_ENABLE           BIT(7)
>> > +
>>
>> Might be a good idea to put comment line preceded each group to refer which
>> register it covers.
> Ok.
>
>>
>> > +#define BQ24261_FAULT_MASK             GENMASK(2, 0)
>>
>> Either use GENMASK in each case, or put plain number.
>>
> Ok.

Looking to your definitions again I can say that GENMASK is more
readable. Regarding to BIT() macro you have to do smart choice in each
case separately.

-- 
With Best Regards,
Andy Shevchenko