Re: [PATCH V3 5/5] regulator: max77620: add regulator driver for max77620/max20024

From: Laxman Dewangan
Date: Tue Jan 19 2016 - 02:14:58 EST

Thanks for review.
Here is my view on the some of the review comment.

On Tuesday 19 January 2016 10:59 AM, Krzysztof Kozlowski wrote:
On 14.01.2016 20:32, Laxman Dewangan wrote:

+ return ret;
+static int max77620_init_pmic(struct max77620_regulator *pmic, int id)
This function seems to be used only from max77620_of_parse_cb(). I would
find easier to read if this was located before definition of
max77620_of_parse_cb(). Can you move it (or you had other idea of
placing algorithm)?

I wanted to keep all local function on top which is used on this file and not the regulator ops.
Then implement regulator ops and then probe.
Let me see if I can do anything here.

+ pmic->enable_power_mode[id]) {
+ ret = max77620_regulator_set_power_mode(
+ pmic, pmic->enable_power_mode[id], id);
The 'pmic' argument should be after opening parenthesis, not at new line.

This is done for indenting alignment. I am using checkpatch --strict option and for this the next line should be on same column of first charcter after opening parenthesis.
To avoid this error, if we want to re-align the indenting for next line then left the line empty after "(".

+static int __init max77620_regulator_init(void)
+ return platform_driver_register(&max77620_regulator_driver);

Does it have to be subsys_initcall? Any special requirements for
ordering the drivers? Probe deferring is encouraged instead.

This is to make sure th regulators are ready before other driver get probed. This is basic need of some of driver and hence subsys_initcall.
I will move to module_init() as some of other PMIC driver (as3722) is in the module init and used in tegra platform so not seeing much issue on this.