Re: [PATCH RESEND] omap_hdq: fix usecount handling

From: Vignesh R
Date: Tue Jan 19 2016 - 06:58:09 EST




On 01/16/2016 06:18 PM, Andreas Kemnade wrote:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> ---

Reviewed-by: Vignesh R <vigneshr@xxxxxx>

Thanks,

> drivers/w1/masters/omap_hdq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
> hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
> ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
> /* Write followed by a read, release the module */
> if (hdq_data->init_trans) {
>

--
Regards
Vignesh