Re: [PATCH] crypto: ixp4xx: avoid uninitialized variable use
From: Arnd Bergmann
Date: Tue Jan 19 2016 - 10:04:26 EST
On Tuesday 19 January 2016 09:00:21 Herbert Xu wrote:
> Subject: crypto: ixp4xx - Fix false lastlen uninitialised warning
> This patch fixes a false positive uninitialised variable warning
> in aead_perform by moving the source processing in front of the
> destination processing, thus ensuring that the initialisation of
> lastlen is always visible to gcc.
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
I've checked that the warnings are now gone, and after reviewing the
code again, I see now that it was indeed a false positive,
contrary to what I thought before.
Patch looks good.
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>