Re: [PATCH V3 00/21] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI

From: Mark Salter
Date: Tue Jan 19 2016 - 18:37:56 EST

On Tue, 2016-01-19 at 20:40 +0000, Russell King - ARM Linux wrote:
> On Tue, Jan 19, 2016 at 02:25:13PM -0600, Bjorn Helgaas wrote:
> > On Mon, Jan 18, 2016 at 02:04:05PM +0000, Graeme Gregory wrote:
> > > After some private debugging with Mark it turned out that the difference
> > > between our configurations was I did not have.
> > >
> > >
> > > With this enabled then the card works without coherent mask hack.
> >
> > I didn't follow the whole discussion here, but is this a case where
> > the driver could fail more gracefully than it did?ÂÂCan we do anything
> > to make this easier for the next person who trips over the same problem?
> I've not followed the discussion at all, but reading what was in the
> quoted parts of the mail makes me somewhat suspicious.
> The way PCI drivers (or in fact any driver) are supposed to work is:
> - the bus code sets up a default mask (32-bit DMA in the case of PCI)
> - the driver calls dma_set_mask() or similar function with the mask
> Â the _driver_ wants to use.ÂÂArch DMA code decides whether the mask
> Â can be supported, and if it can, it re-sets the DMA mask.ÂÂIf the
> Â mask can't be supported, it returns an error.
> The driver is doing things correctly:
> ÂÂÂÂÂÂÂÂif ((sizeof(dma_addr_t) > 4) &&
> ÂÂÂÂÂÂÂÂÂÂÂÂ!pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) && use_dac) {
> ÂÂÂÂÂÂÂÂ} else {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂrc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
> which says: if the size of a DMA address supports 64-bit, and we can
> set a 64-bit DMA address mask (iow, the platform allows it), and
> we're permitted to use DAC, use DAC, otherwise try to set a 32-bit
> DMA mask.
> It shouldn't matter one bit what the mask is before that point.
> However, what the driver fails to do is to deal with the coherent
> mask - it appears to be missing a call to pci_set_consistent_dma_mask().
> That may be where the issue is.

It is.

The driver works with devicetree because of_dma_configure() sets up dma
and coherent mask for PCI devices based on root bridge info in the DT.
So the driver gets by without setting coherent mask explicitly. In the
ACPI case, the coherent mask doesn't get set because there isn't DMA
info in the ACPI tables (I think IORT table/IOMMU support will add this
in the future). Using CONFIG_DMA_CMA avoids the issue by allowing CMA
memory to be used for DMA while avoiding a check against coherent mask.

> It may be worth doing what I did with the DMA API, and introducing
> pci_set_mask_and_coherent() which sets both masks together - which
> will probably allow some PCI driver code to be simplified.