Re: [PATCH v6 0/2] power: act8945a: add charger driver for the sub-device of ACT8945A MFD
From: Lee Jones
Date: Wed Jan 20 2016 - 06:33:12 EST
It really is unacceptable to be sending out so many versions at such
short intervals, essentially spamming the list. This infraction is
worsened by the amount of people you have on CC, most of them for no
reason. This set shouldn't hit my inbox at all, let alone 4 times in
> The ACT8945A is a Multi Function Device with the following subdevices:
> - Regulator
> - Charger
> This patch set is to add regulator driver for ACT8945A.
> It is based on the patch set:
> Changes in v6:
> - change the type value to unsigned int.
> Changes in v5:
> - remove spare spaces after #define.
> - add OF match table.
> - collect Reviewed-by from Krzysztof.
> Changes in v4:
> - use spaces after #define, not tabs.
> - use BIT(n) macros to substitute (0x01 << x).
> - change dt properties with more legible name.
> - change the properties with more legible name, clearer description.
> Changes in v3:
> - update the file header with short version license and author line.
> - remove unused member of struct act8945a_charger, dev.
> - action due to removing the member of stuct act8945a_dev, dev.
> - remove the unnecessary print out.
> - remove the unnecessary act8945a_charger_remove().
> - fix align of the code-style.
> Changes in v2:
> 1./ Substitute of_property_read_bool() for of_get_property().
> 2./ Substitute devm_power_supply_register() for power_supply_register().
> 3./ Use module_platform_driver(), instead of subsys_initcall().
> 4./ Substitute MODULE_LICENSE("GPL") for MODULE_LICENSE("GPL v2").
> Wenyou Yang (2):
> power: act8945a: add charger driver for ACT8945A
> power: add documentation for ACT8945A's charger DT bindings
> .../devicetree/bindings/power/act8945a-charger.txt | 33 ++
> drivers/power/Kconfig | 7 +
> drivers/power/Makefile | 1 +
> drivers/power/act8945a_charger.c | 375 ++++++++++++++++++++
> 4 files changed, 416 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/act8945a-charger.txt
> create mode 100644 drivers/power/act8945a_charger.c
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog