Re: [PATH v2] NVMe: init nvme queue before enabling irq

From: Keith Busch
Date: Wed Jan 20 2016 - 09:57:46 EST


On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote:
> From: Wenbo Wang <wenbo.wang@xxxxxxxxxxxx>
>
> During reset process, the nvme_dev->bar (ioremapped) may change,
> so nvmeq->q_db shall be also updated by nvme_init_queue().
>
> Currently nvmeq irq is enabled before queue init, so a spurious
> interrupt triggered nvme_process_cq may access nvmeq->q_db just
> before it is updated, this could cause kernel panic.
>
> Signed-off-by: Wenbo Wang <wenbo.wang@xxxxxxxxxxxx>
> Reviewed-by: Wenwei Tao <wenwei.tao@xxxxxxxxxxxx>

Looks good, thanks for the fix.

Acked-by: Keith Busch <keith.busch@xxxxxxxxx>