Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller

From: Måns Rullgård
Date: Wed Jan 20 2016 - 11:11:06 EST


Marc Zyngier <marc.zyngier@xxxxxxx> writes:

>> + if (of_property_read_u32(node, "reg", &ctl))
>> + panic("%s: failed to get reg base", node->name);
>> +
>> + chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>> + chip->ctl = ctl;
>> + chip->base = base;

As I said before, this assumes the outer DT node uses a ranges
property. Normally reg properties work the same whether they specify an
offset within an outer "ranges" or have a full address directly. It
would be easy enough to make this work with either, so I don't see any
reason not to.

--
Måns Rullgård