Re: [PATCH v3 0/4] s2mps11 clock driver refactoring
From: Krzysztof Kozlowski
Date: Wed Jan 20 2016 - 19:18:28 EST
On 20.01.2016 19:14, Andi Shyti wrote:
> This patchset contains some code refactoring on the s2mps11 clock
> device driver. The main goal is to remove some dead code and
> improve its readability.
> At any iteration the patchset is getting a patch more, so that
> this time there are four patches :)
Which means that if I have more comments now, you will send a v5 with 5
patches inside? Oh...
> Thanks to Krzysztof for his review, the changset is coming from
> his suggestions:
> V1 -> V2
> - the order of the patches has changed
> - the second patch has been added and it merges a for loop
> a previous one
> - the 3rd patch (which in the first version was the 1st)
> contains some more redundant variables removal.
> V2 -> V3
> - The "merge two for loops in one" has been moved as first patch
> - removed the global variable clk_data
> The patches have been applied on next-20160120 and tested on
> Odroid Xu4.
> Andi Shyti (4):
> clk: s2mps11: merge two for loops in one
> clk: s2mps11: allocate only one structure for clock init
> clk: s2mps11: remove redundant static variables declaration
> clk: s2mps11: remove redundant code
> drivers/clk/clk-s2mps11.c | 108 +++++++++++++---------------------------------
> 1 file changed, 31 insertions(+), 77 deletions(-)