Re: [PATCH v3 2/4] clk: s2mps11: allocate only one structure for clock init

From: Krzysztof Kozlowski
Date: Wed Jan 20 2016 - 19:24:04 EST

On 20.01.2016 19:14, Andi Shyti wrote:
> The driver allocates three structures, s2mpsxx_clk_init, for
> three different clock types (s2mps11, s2mps13 and s2mps14). They
> are quite similar but they differ only by the name. Only one of
> these structures is used, while the others lie unused in the
> memory.
> The clock's name, though, is not such a meaningful information
> and by assigning the same name to the initial data we can avoid
> over allocation. The common name chosen will be s2mps11,
> coherently with the device driver name, instead of the clock
> device.
> Therefore, remove the structures associated to s2mps13 and
> s2mps14 and use only the one referred to s2mps11 for all kind of
> clocks.
> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
> drivers/clk/clk-s2mps11.c | 51 +++++++----------------------------------------
> 1 file changed, 7 insertions(+), 44 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,