Re: [PATCH] spi: qup: provide proper bus numbers

From: Mark Brown
Date: Thu Jan 21 2016 - 13:38:23 EST


On Thu, Jan 21, 2016 at 06:33:47PM +0000, Srinivas Kandagatla wrote:

> This driver reuses pdev->id for spi bus numbers resulting in random
> or very large bus numbering when used with device trees. pdev->id
> is not the correct choice when using device trees. So add code to

What makes you say this, why is pdev->id not "correct"? It is worrying
if anything cares what number we pick.

> get bus numbers via device tree aliases and if it fails then generate
> a unique bus number.

The other question is even if this is a good idea why is it something
that should be open coded in individual drivers, if we want to change
the policy we should be consistent between drivers.

Attachment: signature.asc
Description: PGP signature