Re: [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_*

From: Borislav Petkov
Date: Thu Jan 21 2016 - 14:04:47 EST


On Thu, Jan 21, 2016 at 10:57:06AM -0800, H. Peter Anvin wrote:
> On 01/21/16 10:34, Borislav Petkov wrote:
> > +#ifndef _ASM_X86_REQUIRED_FEATURES_H
>
> Why do we have all these include guards at the point of the #include?
> This is not standard procedure.

Some uapi monkey business:

abbf1590de22 ("UAPI: Partition the header include path sets and add uapi/ header directories")

The funny thing is, the headers themselves have the guards too. I'll try
to remove them to see what breaks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.