Re: [PATCH] spi: qup: provide proper bus numbers

From: Mark Brown
Date: Thu Jan 21 2016 - 15:14:37 EST

On Thu, Jan 21, 2016 at 07:26:19PM +0000, Srinivas Kandagatla wrote:
> On 21/01/16 19:03, Mark Brown wrote:

> >That doesn't help explain why it is a good idea to open code this in
> >individual drivers. I was asking why it's a good idea to do this in a
> >single driver rather than at a higher level.

> Oops!!, I should have looked at spi.c which already does exactly same thing.
> I think the logic did not get triggered because (int)-1 overflowed into s16
> busnum.

Ah, that sounds like a bug... I'd actually forgotten that we did that,
it should work though since the code is there and it (hopefully) worked
at some point.

Attachment: signature.asc
Description: PGP signature