Re: [PATCH v2 5/5] perf/x86/amd/power: Add AMD accumulated power reporting mechanism
From: Borislav Petkov
Date: Fri Jan 22 2016 - 12:51:39 EST
On Fri, Jan 22, 2016 at 04:04:40PM +0800, Huang Rui wrote:
> OK, you're right. Peter, Boris, thanks for your information.
> I might need look at topology deeper. :-)
> So how about below update:
Please send a full patch, not those diffs ontop - I don't know about
Peter but I absolutely can't grok it this way.
> BTW, "smp_num_siblings = ((ebx >> 8) & 3) + 1" should not put under
> init_amd(), we would better move it to bsp_init_amd(). Because the AMD
> "smp_num_siblings" number must be constant.
You can send me a fix once your other stuff hits tip and you can base it
ECO tip #101: Trim your mails when you reply.