Re: [PATCH] mtd: nand: mpc5121: use 'of_machine_is_compatible' to simplify code

From: Brian Norris
Date: Fri Jan 22 2016 - 19:36:44 EST


On Mon, Jan 11, 2016 at 01:55:58PM +0100, Boris Brezillon wrote:
> On Sun, 10 Jan 2016 07:46:39 +0100
> Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:
>
> > The current code is the same as 'of_machine_is_compatible'.
> > So use it in order to remove a few lines of code and to be more
> > consistent with other parts of the kernel.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> Your patch looks good from a functional POV, but what is this board
> detection hack doing in the NAND driver code in the first place?
>
> Let's say I didn't see that :-).

:)

> Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>

Applied to l2-mtd.git/next