Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional

From: Mark Brown
Date: Mon Jan 25 2016 - 08:53:24 EST

On Mon, Jan 25, 2016 at 01:51:09PM +0100, Lothar Waßmann wrote:
> On Mon, 25 Jan 2016 12:41:23 +0000 Mark Brown wrote:

> > The above, for example - make the interrupt optional.

> This will make it impossible to notify the system about
> overtemperature (and undervoltage).
> I implemented polling to be able to get at least overtemperature
> warnings.
> (Undervoltage cannot be handled sensibly without interrupt anyway)

I'm not convinced that justifies constantly polling, if the system
designers cared you'd hope they'd have wired it up to a working
interrupt. People commonly don't, realistically thermal warnings are
usually set near the point where the silicon will be physically damaged
and typically by the time they fire the system is already experiencing
catastrophic problems at a system level.

The polling is at the very least a separate change, and making the
interrupt work would be a much better option.

Attachment: signature.asc
Description: PGP signature