Re: [PATCH v2] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc

From: Paul Bolle
Date: Mon Jan 25 2016 - 10:03:35 EST

On ma, 2016-01-25 at 12:15 +0100, Christian Borntraeger wrote:
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug

> + bool "Enable debug page memory allocations by default?"
> + default off

Nit: you apparently meant
default n

Note that "default off" should also evaluate to "n", which probably
explains why you didn't notice. And "n" is the default anyhow.

So I'm guessing you might as well drop this line.

> + depends on DEBUG_PAGEALLOC
> + ---help---
> + Enable debug page memory allocations by default? This value
> + can be overridden by debug_pagealloc=off|on.
> +
> + If unsure say no.

(Really trivial: you start indentation both with spaces and with tabs.
Start with tabs, please.)

Paul Bolle