Re: [PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig

From: Daniel Vetter
Date: Mon Jan 25 2016 - 10:38:31 EST


On Mon, Jan 25, 2016 at 12:41:19PM +0100, Andreas Ziegler wrote:
> Commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access
> through GGTT on Braswell") depended upon a working stop_machine() and
> so forced the selection of STOP_MACHINE. However, commit 86fffe4a61dd
> ("kernel: remove stop_machine() Kconfig dependency") removed the option
> STOP_MACHINE from init/Kconfig and ensured that stop_machine()
> universally works. Due to the order in which the patches were applied,
> removing the select from DRM_I915 got lost during merging.
>
> Remove the now obsolete select statement.
>
> Signed-off-by: Andreas Ziegler <andreas.ziegler@xxxxxx>
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Applied, thanks.
-Daniel

> ---
> Changes to v1:
> - Tell the story right, suggested by Chris Wilson
>
> drivers/gpu/drm/i915/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index fcd77b2..051eab3 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -10,7 +10,6 @@ config DRM_I915
> # the shmem_readpage() which depends upon tmpfs
> select SHMEM
> select TMPFS
> - select STOP_MACHINE
> select DRM_KMS_HELPER
> select DRM_PANEL
> select DRM_MIPI_DSI
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch