Re: [PATCH 1/2] [media] m88rs6000t: Better exception handling in five functions
From: SF Markus Elfring
Date: Mon Jan 25 2016 - 13:20:40 EST
>> This issue was detected by using the Coccinelle software.
>> Move the jump label directly before the desired log statement
>> so that the variable "ret" will not be checked once more
>> after a function call.
>> Use the identifier "report_failure" instead of "err".
>> Suggested-by: Julia Lawall <julia.lawall@xxxxxxx>
>> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> drivers/media/tuners/m88rs6000t.c | 154 +++++++++++++++++++-------------------
>> 1 file changed, 78 insertions(+), 76 deletions(-)
>> diff --git a/drivers/media/tuners/m88rs6000t.c b/drivers/media/tuners/m88rs6000t.c
>> index 504bfbc..7e59a9f 100644
>> --- a/drivers/media/tuners/m88rs6000t.c
>> +++ b/drivers/media/tuners/m88rs6000t.c
>> @@ -44,7 +44,7 @@ static int m88rs6000t_set_demod_mclk(struct dvb_frontend *fe)
>> /* select demod main mclk */
>> ret = regmap_read(dev->regmap, 0x15, &utmp);
>> if (ret)
>> - goto err;
>> + goto report_failure;
> Why to be so verbose?
Does the document "CodingStyle" give an indication in the section "Chapter 7:
Centralized exiting of functions"?
> Calling it as "err" is enough,
It seems that some short identifiers are popular during software development.
> and it means less code to type if we need to add another goto.
Would you like to increase the usage of jump labels which will contain
only a single character?