Re: [PATCH v2 01/16] dell-laptop: extract SMBIOS-related code to a separate module

From: MichaÅ KÄpieÅ
Date: Tue Jan 26 2016 - 08:34:01 EST


> Hi MichaÅ,
>
> [auto build test ERROR on platform-drivers-x86/for-next]
> [also build test ERROR on v4.4 next-20160122]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Micha-K-pie/Common-Dell-SMBIOS-API/20160122-223550
> base: git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-next
> config: x86_64-randconfig-n0-01240935 (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> drivers/platform/x86/dell-smbios.c: In function 'dell_send_request':
> >> drivers/platform/x86/dell-smbios.c:71:16: error: implicit declaration of function 'virt_to_phys' [-Werror=implicit-function-declaration]
> command.ebx = virt_to_phys(buffer);
> ^
> cc1: some warnings being treated as errors

Nice catch, turns out I missed the <linux/io.h> include in
dell-smbios.c, but that only causes errors for non-SMP builds.

I'll keep that in mind for v3 of this series, if it happens. If not,
I'll post a v3 of just this patch once the rest of the series gets
acked.

--
Best regards,
MichaÅ KÄpieÅ