Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()

From: Andi Shyti
Date: Tue Jan 26 2016 - 20:22:38 EST


Hi Javier,

> if (tm->tm_year < 100) {
> - pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
> - 1900 + tm->tm_year);
> + dev_warn(info->dev,
> + "RTC can't handle year %d. Assume it's 2000\n",
> + 1900 + tm->tm_year);
> return -EINVAL;

Because we are returning an error value, why not use dev_err()?

> }
> } else {
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html