Re: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list

From: Viresh Kumar
Date: Wed Jan 27 2016 - 01:36:19 EST


On 27-01-16, 12:02, Gautham R. Shenoy wrote:
> Currently next_policy() explicitly checks if a policy is the last
> policy in the cpufreq_policy_list. Use the standard list_is_last
> primitive instead.
>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Signed-off-by: Gautham R. Shenoy <ego@xxxxxxxxxxxxxxxxxx>
> ---
> The earlier version one was based on an Juri's experimental branch.
> I have based this one on linux-pm.git linux-next branch.
>
> drivers/cpufreq/cpufreq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index c35e7da..e979ec7 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -48,11 +48,11 @@ static struct cpufreq_policy *next_policy(struct cpufreq_policy *policy,
> bool active)
> {
> do {
> - policy = list_next_entry(policy, policy_list);
> -
> /* No more policies in the list */
> - if (&policy->policy_list == &cpufreq_policy_list)
> + if (list_is_last(&policy->policy_list, &cpufreq_policy_list))
> return NULL;
> +
> + policy = list_next_entry(policy, policy_list);
> } while (!suitable_policy(policy, active));
>
> return policy;

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh