Re: [PATCH] lib: fix callers of strtobool to use char array
From: Kees Cook
Date: Wed Jan 27 2016 - 20:03:30 EST
On Wed, Jan 27, 2016 at 4:58 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Wed, 2016-01-27 at 16:45 -0800, Kees Cook wrote:
>> Some callers of strtobool were passing a pointer to unterminated strings.
>> This fixes the issue and consolidates some logic in cifs.
> This may be incomplete as it duplicates the behavior for
> the old number of characters, but this is not a solution
> for the entry of a bool that is "on" or "off".
As in, the on/off patch is missing? Yes, that's been sent separately,
but I wanted to make sure these changes weren't upsetting to the two
>> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
>> @@ -290,7 +305,8 @@ static ssize_t cifs_stats_proc_write(struct file *file,
>> - }
>> + } else
>> + return rc;
> Likely better to reverse the test and unindent the
> preceding block.
> Otherwise, please make sure to use the general brace
> form of when one branch needs braces, the other branch
> should have them too.
Okay, sure, I'll rework this and send it together with the on/off patch.
Chrome OS & Brillo Security