Re: [PATCH 22/31] media: dvb-core create tuner to demod pad link in disabled state

[Shuah Khan]

On 01/28/2016 09:38 AM, Mauro Carvalho Chehab wrote:
> Em Wed,  6 Jan 2016 13:27:11 -0700
> Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> escreveu:
> 
>> Create tuner to demod pad link in disabled state to help avoid
>> disable step when tuner resource is requested by video or audio.
>>
>> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/media/dvb-core/dvbdev.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
>> index b56e008..1d10fa6 100644
>> --- a/drivers/media/dvb-core/dvbdev.c
>> +++ b/drivers/media/dvb-core/dvbdev.c
>> @@ -593,8 +593,9 @@ int dvb_create_media_graph(struct dvb_adapter *adap)
>>  	}
>>  
>>  	if (tuner && demod) {
>> +		/* create tuner to demod link deactivated */
>>  		ret = media_create_pad_link(tuner, TUNER_PAD_IF_OUTPUT,
>> -					    demod, 0, MEDIA_LNK_FL_ENABLED);
>> +					    demod, 0, 0);
> 
> This is not right, as it makes no sense for DVB-only drivers.

Right. Not a good change for DVB only drivers. But does make
sense on hybrid. I will make sure it gets done only in hyrbid
cases.

thanks,
-- Shuah

> 
>>  		if (ret)
>>  			return ret;
>>  	}


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978