Re: [PATCH V6 7/8] DT: regulator: add DT binding doc for regulator of PMIC max77620/max20024

From: Mark Brown
Date: Thu Jan 28 2016 - 18:28:51 EST

On Thu, Jan 28, 2016 at 07:07:53PM +0530, Laxman Dewangan wrote:
> Maxim Semiconductor's PMIC MAX77620/MAX20024 has multiple
> DCDCs and LDOs.

Please use subject lines matching the style for the subsystem. I'm
fairly sure I've mentioned this before and really if your subject lines
don't visually resemble anything else in the directory that ought to be
a warning sign.

> +- maxim,disable-active-discharge: boolean, Disable active discharge.

That's something I've seen other regulators do, can we make it a
standard property with an op?

> +max77620@3c {
> + regulators {
> + in-ldo0-1-supply = <&max77620_sd2>;
> + in-ldo7-8-supply = <&max77620_sd2>;

I'd expect any supplies for the device to be at the device level,
including supplies used by regulators.

Attachment: signature.asc
Description: PGP signature