Re: [PATCH] pinctrl: nomadik: hide unused functions

From: Uwe Kleine-König
Date: Fri Jan 29 2016 - 02:30:49 EST

Hello Arnd,

On Mon, Jan 25, 2016 at 04:59:09PM +0100, Arnd Bergmann wrote:
> The nomadik pinctrl driver has two functions that are only used
> for debugfs output and are otherwise unused:
> drivers/pinctrl/nomadik/pinctrl-abx500.c:194:12: error: 'abx500_get_pull_updown' defined but not used
> drivers/pinctrl/nomadik/pinctrl-abx500.c:471:12: error: 'abx500_get_mode' defined but not used
> This makes the function definitions conditional to avoid the
> harmless warnings.
> [...]
> static int abx500_get_pull_updown(struct abx500_pinctrl *pct, int offset,
> enum abx500_gpio_pull_updown *pull_updown)

an alternative is to mark the functions with __maybe_unused. I just
noticed that Documentation/CodingStyle even mandates to use that instead
of cpp stuff.

Best regards

Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | |