Re: [PATCH 4/5] mm: Use radix_tree_iter_retry()

From: Matthew Wilcox
Date: Fri Jan 29 2016 - 09:50:48 EST


On Fri, Jan 29, 2016 at 03:45:59PM +0100, Vlastimil Babka wrote:
> This should be applied on top. There are no restarts anymore.

Quite right. Sorry I missed the comment.

Acked-by: Matthwe Wilcox <willy@xxxxxxxxxxxxxxx>

> ----8<----
> >From 3b0bdd370b57fb6d83b213e140cd1fb0e8962af8 Mon Sep 17 00:00:00 2001
> From: Vlastimil Babka <vbabka@xxxxxxx>
> Date: Fri, 29 Jan 2016 15:41:31 +0100
> Subject: [PATCH] mm: Use radix_tree_iter_retry()-fix
>
> Remove now-obsolete-and-misleading comment.
>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
> ---
> mm/shmem.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 8f89abd4eaee..4d758938340c 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -382,11 +382,6 @@ unsigned long shmem_partial_swap_usage(struct address_space *mapping,
>
> page = radix_tree_deref_slot(slot);
>
> - /*
> - * This should only be possible to happen at index 0, so we
> - * don't need to reset the counter, nor do we risk infinite
> - * restarts.
> - */
> if (radix_tree_deref_retry(page)) {
> slot = radix_tree_iter_retry(&iter);
> continue;
> --
> 2.7.0
>
>