Re: [PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps

From: Kevin Smith
Date: Fri Jan 29 2016 - 10:24:21 EST


On 01/28/2016 08:18 PM, Andrew Lunn wrote:
> On Thu, Jan 28, 2016 at 04:54:37PM -0500, Vivien Didelot wrote:
>> Currently the port based VLAN maps should be configured to allow every
>> port to egress frames on all other ports, except themselves.
>>
>> The debugfs interface shows that they are misconfigured. For instance, a
>> 7-port switch has the following content in the related register 0x06:
>>
>> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6
>> ...
>> 6: 1fa4 1f0f 4 7f 7e 7d 7c 7b 7a 79
>> ...
>>
>> This means that port 3 is allowed to talk to port 2-6, but cannot talk
>> to ports 0 and 1. With this fix, port 3 can correctly talk to all ports
>> except 3 itself:
>>
>> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6
>> ...
>> 6: 1fa4 1f0f 4 7e 7d 7b 77 6f 5f 3f
>> ...
>>
>> Fixes: ede8098d0fef ("net: dsa: mv88e6xxx: bridges do not need an FID")
>> Reported-by: Kevin Smith <kevin.smith@xxxxxxxxxxxxxxx>
>> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Tested-by: Kevin Smith <kevin.smith@xxxxxxxxxxxxxxx>