Re: [PATCH 03/15] mips: use of_platform_default_populate() to populate default bus

From: Kefeng Wang
Date: Fri Jan 29 2016 - 21:53:50 EST




On 2016/1/30 0:00, Joshua Henderson wrote:
> On 01/26/2016 09:27 PM, Kefeng Wang wrote:
>> Use helper of_platform_default_populate() in linux/of_platform
>> when possible, instead of calling of_platform_populate() with
>> the default match table.
>>
>> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
>> ---
>> arch/mips/ath79/setup.c | 2 +-
>> arch/mips/jz4740/setup.c | 2 +-
>> arch/mips/mti-sead3/sead3-setup.c | 2 +-
>> arch/mips/pic32/pic32mzda/init.c | 3 +--
>> arch/mips/pistachio/init.c | 2 +-
>> arch/mips/xilfpga/init.c | 2 +-
>> 6 files changed, 6 insertions(+), 7 deletions(-)
>>
>
> [...]
>
>> diff --git a/arch/mips/pic32/pic32mzda/init.c b/arch/mips/pic32/pic32mzda/init.c
>> index 775ff90..77ecf32 100644
>> --- a/arch/mips/pic32/pic32mzda/init.c
>> +++ b/arch/mips/pic32/pic32mzda/init.c
>> @@ -147,8 +147,7 @@ static int __init plat_of_setup(void)
>> panic("Device tree not present");
>>
>> pic32_of_prepare_platform_data(pic32_auxdata_lookup);
>> - if (of_platform_populate(NULL, of_default_bus_match_table,
>> - pic32_auxdata_lookup, NULL))
>> + if (of_platform_default_populate(NULL, pic32_auxdata_lookup, NULL))
>> panic("Failed to populate DT");
>>
>> return 0;
>
> I'll one-up just compile-testing for this.

Hi Joshua, Many thanks.

>
> Tested-by: Joshua Henderson <joshua.henderson@xxxxxxxxxxxxx>
>
> [...]
>
>
> .
>