Re: [PATCH v3] dmi: Make dmi_walk and dmi_walk_early return real error codes

From: Jean Delvare
Date: Sat Jan 30 2016 - 14:19:37 EST

On Sat, 30 Jan 2016 10:13:09 -0800, Andy Lutomirski wrote:
> On Sat, Jan 30, 2016 at 10:05 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> > If I understand this correctly, this is the first of 5 patches, and this one has
> > some unanswered questions from Jean here. If this patch gets respun, the
> > following are also impacted:
> >
> > dell-wmi: Stop storing pointers to DMI tables
> > dell-wmi, dell-laptop: select DMI
> > dell-wmi: Clean up hotkey table size check
> > dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake)
> >
> > Is that correct?
> Not really. It's just the three patches here:
> This patch (the dmi_walk error code one) is no longer really related.
> Due to Jean's earlier comment about what happens if DMI isn't enabled
> at all, I no longer propagate the error code from dmi_walk in
> dell-wmi, so the error code won't have any effect. (Instead I just
> warn and let the driver load in legacy mode, which matches the current
> behavior.)
> I think the way to go is for the v3 "dell-wmi: DMI misuse fixes"
> series to go in through your tree, and I'll hash out the error code
> thing separately with Jean.
> Does that seem sensible?

Yes, I agree that this patch is independent from the dell-wmi patch
series now.

Jean Delvare
SUSE L3 Support