Re: [PATCH net v2 1/4] net/core: relax BUILD_BUG_ON in netdev_stats_to_stats64
From: David Miller
Date: Sat Jan 30 2016 - 18:27:02 EST
From: Jarod Wilson <jarod@xxxxxxxxxx>
Date: Sat, 30 Jan 2016 15:53:05 -0500
> On Sat, Jan 30, 2016 at 03:39:01PM -0500, Jarod Wilson wrote:
>> Ew, no, it won't work correctly on 32-bit. The for loop is going to copy
>> data into dst from beyond the end of netdev_stats, and the range looks
>> like it won't be right either, only half of the added stats64 space will
>> get zeroed out. Okay, I'll fix that up correctly.
> Completely untested as of yet, but I think something like the following
> looks correct. I'll give it a spin as soon as I can.
Jarod, please respin your entire series as a v3 once you sort this out.