Re: [PATCH v2] gpio: Add driver for TI TPIC2810

From: Andy Shevchenko
Date: Sun Jan 31 2016 - 17:52:50 EST

On Thu, Jan 28, 2016 at 4:56 PM, Andrew F. Davis <afd@xxxxxx> wrote:
> On 01/28/2016 04:47 AM, Linus Walleij wrote:

>> So the TI datasheet says:
>> "8 bit LED driver with I2C interface"
>> So it is *not* "general purpose input/output" (GPIO).
>> It is special purpose LED drive output-only circuit.
>> So why can it not have a driver directly in drivers/leds/*?
>> I understand that it can also be used as a GPIO (and that it
>> is then nice to put leds-gpio on top of it) but then
>> I want a reference to the hardware that actually went ahead
>> and used this as a GPIO chip rather than using a proper
>> GPIO expander.

> These don't really have the traditional LED features (current control,
> HW blinking, etc), and all the use cases I've found treat them as GPO,
> including our Industrial Dev Kitsâ

It reminds me how 12 channel PWM chip is used on Intel Galileo Gen 2.
Half pins are PWM, the other half is GPIO used for discrete based pin
muxing and control. Nevertheless I think it's a userspace issue for
now, otherwise we have to provide some 'semi-virtual' way of
presenting pins as GPIO lines.

just my 2 cents.

With Best Regards,
Andy Shevchenko