Re: [PATCH][v2] ACPI: Do not report _OSI("Darwin") when acpi_osi=!Darwin provided

From: Andy Shevchenko
Date: Mon Feb 01 2016 - 03:54:31 EST


On Mon, Feb 1, 2016 at 4:26 AM, Chen Yu <yu.c.chen@xxxxxxxxx> wrote:
> Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always
> reports positive value when Apple hardware queries _OSI("Darwin").
> But sometimes the users might want to tell the hardware they don't
> need the Darwin feature, for example, users may leverage the hardware
> to power off the Thunderbolt, by appending acpi_osi=!Darwin in command
> line, thus Apple hardware regards it as an incompatible OS X system,
> hence turns off the Thunderbolt.


> +static bool acpi_osi_setup_disabled(char *str)
> +{
> + int i;
> + struct osi_setup_entry *osi;
> +
> + if (!str)
> + return false;
> +
> + for (i = 0; i < OSI_STRING_ENTRIES_MAX; i++) {
> + osi = &osi_setup_entries[i];
> + if (!strcmp(osi->string, str)) {

Seems like we have one more user for
http://www.spinics.net/lists/kernel/msg2157535.html

> + if (!osi->enable)
> + return true;
> + else
> + return false;

return !osi->enable;

> + }
> + }
> +
> + return false;
> +}


--
With Best Regards,
Andy Shevchenko