Re: [PATCH v2] x86/mm: avoid premature success when changing page attributes

From: Jan Beulich
Date: Tue Feb 02 2016 - 03:46:24 EST


>>> On 28.01.16 at 09:42, <mingo@xxxxxxxxxx> wrote:
> Could we try a v3?

Okay, I withdraw the patch: Upon further consideration it is note
really clear what the intended behavior of set_memory_*() on
address ranges with mapping holes is supposed to be. The original
issue was with set_memory_nx() (called from mark_rodata_ro())
stumbling across an unmapped region (resulting from an out of
tree change completely unmapping the kernel mappings of
address ranges passed to free_init_pages()). I simply don't have
the time to check whether the unmapping done with
CONFIG_DEBUG_PAGEALLOC would have a similar effect. The
net result in any event were pages (past the hole) reported as
problematic when CONFIG_DEBUG_WX is enabled.

Jan