Re: [RFC 00/26] perf tools: Introduce hists specific format entries

From: Arnaldo Carvalho de Melo
Date: Tue Feb 02 2016 - 17:25:30 EST


Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
> wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
> no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
> ->{fields,sorts} as Namhyung suggested and you agreed, it builds...
>
> But perf top isn't showing the overhead column... there were some
> changes to perf report in this patchkit to move some initializations...
> will check there...

Double checking...

[acme@jouet linux]$ git bisect bad
cd85325039555bbf37d08d399ae2b1c91c70a565 is the first bad commit
commit cd85325039555bbf37d08d399ae2b1c91c70a565
Author: Jiri Olsa <jolsa@xxxxxxxxxx>
Date: Mon Jan 18 10:24:07 2016 +0100

perf hists: Allocate output sort field

Currently we use static output fields, because we have single global
list of all sort/output fields.

We will add hists specific sort and output lists in following patches,
so we need all format entries to be dynamically allocated. Adding
support to allocate output sort field.

Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxx>
Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Link: http://lkml.kernel.org/r/1453109064-1026-10-git-send-email-jolsa@xxxxxxxxxx
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

:040000 040000 f119a49ec0c9954f3117e151719c3c322c1651e4 4bb14abe5005fe29c45eecd9f6fab30fabc0fd99 M tools
[acme@jouet linux]$