Re: [RFC][PATCH] mips: Fix arch_spin_unlock()

From: Paul E. McKenney
Date: Tue Feb 02 2016 - 17:38:24 EST


On Tue, Feb 02, 2016 at 06:23:37PM +0100, Peter Zijlstra wrote:
>
>
> On 2 February 2016 07:44:33 CET, "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
>
> >
> >> If so, do we also need to take the following pairing into
> >consideration?
> >>
> >> o smp_store_release() -> READ_ONCE(); if ;smp_rmb(); <ACCESS_ONCE()>
>
>
> We rely on this with smp_cond_aquire() to extend the chain.

We do indeed! And it is not possible to use smp_load_acquire() given
this API becauseof the "!". Hmmm...

If this one turns out to be problematic, there are some ways of dealing
with it. But thank you for reminding me of it. I think, anyway. ;-)

Thanx, Paul