Re: [PATCH 1/2] gpio: Include linux/gpio.h instead of asm/gpio.h
From: Alexandre Courbot
Date: Tue Feb 02 2016 - 19:02:49 EST
On Wed, Feb 3, 2016 at 4:53 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> Most arches have an asm/gpio.h that merely includes linux/gpio.h. The
> others select ARCH_HAVE_CUSTOM_GPIO_H, and when that's selected,
> linux/gpio.h includes asm/gpio.h.
Looks correct if that's really what happens, GPIO includes can be tricky...
> arch/avr32/boards/merisc/setup.c | 1 -
> arch/avr32/mach-at32ap/pio.c | 2 +-
> arch/blackfin/kernel/debug-mmrs.c | 2 +-
> arch/blackfin/mach-bf538/boards/ezkit.c | 2 +-
> arch/blackfin/mach-bf538/ext-gpio.c | 2 +-
> arch/blackfin/mach-bf548/boards/cm_bf548.c | 2 +-
> arch/blackfin/mach-bf548/boards/ezkit.c | 2 +-
> arch/blackfin/mach-bf609/boards/ezkit.c | 2 +-
> arch/blackfin/mach-common/ints-priority.c | 2 +-
> arch/blackfin/mach-common/pm.c | 2 +-
> arch/sh/include/mach-common/mach/magicpanelr2.h | 2 +-
> drivers/ata/pata_at91.c | 3 +--
> drivers/ata/pata_bf54x.c | 2 +-
> drivers/gpio/gpio-mpc5200.c | 1 -
> drivers/mfd/menelaus.c | 2 +-
> drivers/mtd/onenand/omap2.c | 2 +-
> drivers/pcmcia/bfin_cf_pcmcia.c | 2 +-
> drivers/pcmcia/pxa2xx_vpac270.c | 1 -
> drivers/usb/gadget/udc/atmel_usba_udc.c | 2 --
> drivers/usb/host/ohci-at91.c | 2 --
> drivers/video/fbdev/atmel_lcdfb.c | 2 --
> drivers/video/fbdev/omap/lcd_h3.c | 2 +-
> drivers/video/fbdev/omap/lcd_osk.c | 3 +--
> drivers/video/fbdev/omap/lcd_palmtt.c | 2 +-
Driver code should most definitely never include asm/gpio.h directly.
I may be overlooking some intricate detail, but the simplification is welcome.
Acked-by: Alexandre Courbot <acourbot@xxxxxxxxxx>