Re: [PATCH v2] floppy: refactor open() flags handling (was Re: mm: uninterruptable tasks hanged on mmap_sem)

From: Jiri Kosina
Date: Fri Feb 05 2016 - 11:40:54 EST


On Fri, 5 Feb 2016, Dmitry Vyukov wrote:

> I don't have any objections. And I agree that it does not make sense
> to spend any considerable time on optimizing this driver.

Yeah, on a second thought this definitely is the way how to deal with this
in this particular driver.

> > Alternatively we can take more conservative aproach, accept the
> > nonblocking flag, but do the regular business of the driver.
> >
> > Actually, let's try that, to make sure that we don't introduce userspace
> > breakage.
> >
> > Could you please retest with the patch below?
>
> Reapplied.

Thanks. Once/if you confirm that syzkaller is not able to reproduce the
problem any more, I'll queue it and push to Jens.

--
Jiri Kosina
SUSE Labs