Re: [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor

From: Jonathan Cameron
Date: Sat Feb 06 2016 - 13:39:00 EST


On 03/02/16 07:55, Matt Ranostay wrote:
> Reviewed-by: Matt Ranostay <mranostay@xxxxxxxxx>
>
> On Tue, Feb 2, 2016 at 6:36 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>> The newly added atlas-ph-sensor driver uses irq_work_queue, which
>> may not always be enabled:
>>
>> ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!
>>
>> This adds a 'select' statement to Kconfig to ensure it's there
>> when we need it.
>>
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> Fixes: 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")
>>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to fail to spot and IRQ_WORK related issues ;)

Thanks,

Jonathan
>> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
>> index ce7cd1370f74..f73290f84c90 100644
>> --- a/drivers/iio/chemical/Kconfig
>> +++ b/drivers/iio/chemical/Kconfig
>> @@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
>> select REGMAP_I2C
>> select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> + select IRQ_WORK
>> help
>> Say Y here to build I2C interface support for the Atlas
>> Scientific OEM pH-SM sensor.
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>