Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch

From: Carlo Caione
Date: Mon Feb 08 2016 - 03:34:26 EST


On Sun, Feb 7, 2016 at 10:13 PM, Andreas FÃrber <afaerber@xxxxxxx> wrote:
> As preparation for arm64 based mesongxbb, which pulls in this code once
> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch.
> The loop uses a local unsigned int variable, so adopt that type,
> matching the header.
>
> Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller")
> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
> ---
> drivers/clk/meson/clkc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clkc.c b/drivers/clk/meson/clkc.c
> index c83ae1367abc..d920d410b51d 100644
> --- a/drivers/clk/meson/clkc.c
> +++ b/drivers/clk/meson/clkc.c
> @@ -198,7 +198,7 @@ meson_clk_register_fixed_rate(const struct clk_conf *clk_conf,
> }
>
> void __init meson_clk_register_clks(const struct clk_conf *clk_confs,
> - size_t nr_confs,
> + unsigned int nr_confs,
> void __iomem *clk_base)
> {
> unsigned int i;

Nit: I'd prefer to fix declaration in drivers/clk/meson/clkc.h with
size_t since we are going to use it for array indexing.

Also please, CC linux-meson@xxxxxxxxxxxxxxxx on meson related patches.

Thanks!

--
Carlo Caione