Re: [PATCH 6/7] [PATCH] MIPS: OCTEON: Add support for OCTEON III interrupt controller.

From: Thomas Gleixner
Date: Mon Feb 08 2016 - 05:40:22 EST


On Fri, 5 Feb 2016, David Daney wrote:
> On 02/05/2016 01:06 AM, Thomas Gleixner wrote:
> > > +int octeon_irq_ciu3_xlat(struct irq_domain *d,
> >
> > static ?
>
> To be used in follow-on patch for MSI-X irq_chip driver residing in a separate
> file.
>
> The idea was to not be changing the to/from static multiple times as the new
> patches were merged. If you think it preferable, I can make them all static
> and then remove the static later, when needed.

Nah. It was just not clear from reading this patch. A hint in the changelog
might be helpful.

Thanks,

tglx