Re: [PATCH 7/8] [media] tvp5150: document input connectors DT bindings

From: Javier Martinez Canillas
Date: Mon Feb 08 2016 - 13:23:37 EST


Hello,

I noticed that I missed the DT folks in the cc list so I'm adding
them now, sorry for the noise...

On 02/05/2016 04:09 PM, Javier Martinez Canillas wrote:
The tvp5150 decoder has different input connectors so extend the device
tree binding to allow device tree source files to define the connectors
that are available on a given board.

Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
---

.../devicetree/bindings/media/i2c/tvp5150.txt | 43 ++++++++++++++++++++++
1 file changed, 43 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/tvp5150.txt b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
index 8c0fc1a26bf0..daa20e43a8e3 100644
--- a/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
+++ b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
@@ -12,6 +12,32 @@ Optional Properties:
- pdn-gpios: phandle for the GPIO connected to the PDN pin, if any.
- reset-gpios: phandle for the GPIO connected to the RESETB pin, if any.

+Optional nodes:
+- connectors: The input connectors of tvp5150 have to be defined under
+ a subnode name "connectors" using the following format:
+
+ input-connector-name {
+ input connector properties
+ };
+
+Each input connector must contain the following properties:
+
+ - label: a name for the connector.
+ - input: the input connector.
+
+The possible values for the "input" property are:
+ 0: Composite0
+ 1: Composite1
+ 2: S-Video
+
+and on a tvp5150am1 and tvp5151 there is another:
+ 4: Signal generator
+
+The list of valid input connectors are defined in dt-bindings/media/tvp5150.h
+header file and can be included by device tree source files.
+
+Each input connector can be defined only once.
+
The device node must contain one 'port' child node for its digital output
video port, in accordance with the video interface bindings defined in
Documentation/devicetree/bindings/media/video-interfaces.txt.
@@ -36,6 +62,23 @@ Example:
pdn-gpios = <&gpio4 30 GPIO_ACTIVE_LOW>;
reset-gpios = <&gpio6 7 GPIO_ACTIVE_LOW>;

+ connectors {
+ composite0 {
+ label = "Composite0";
+ input = <TVP5150_COMPOSITE0>;
+ };
+
+ composite1 {
+ label = "Composite1";
+ input = <TVP5150_COMPOSITE1>;
+ };
+
+ s-video {
+ label = "S-Video";
+ input = <TVP5150_SVIDEO>;
+ };
+ };
+
port {
tvp5150_1: endpoint {
remote-endpoint = <&ccdc_ep>;


Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America