Re: [PATCH v2 2/2] rng: pic32-rng: Add PIC32 RNG hardware driver

From: Daniel Thompson
Date: Mon Feb 08 2016 - 16:34:18 EST


On Mon, Feb 08, 2016 at 02:17:53PM -0700, Joshua Henderson wrote:
> Add support for the hardware true random number generator
> peripheral found on PIC32.
>
> Signed-off-by: Joshua Henderson <joshua.henderson@xxxxxxxxxxxxx>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@xxxxxxxxxxxxx>

Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

> ---
> Changes since v1:
> - Reorder includes to be alphabetic.
> - Drop use of PRNG and only use TRNG.

Excellent!



> - Fix dangling clock ref in error condition.
> - Remove unecessary error handling and fix other cases.


Daniel.