Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

[Jason Gunthorpe]

On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote:
> If the initialization fails before tpm_chip_register(), put_device()
> will be not called, which causes release callback not to be called.
> This patch fixes the issue by adding put_device() to devres list of
> the parent device.

Erm, if you do this, then shouldn't the device_unregister change to
device_del to keep the kref balanced?

Jason