Re: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP

From: Antoine Tenart
Date: Tue Feb 09 2016 - 03:56:48 EST


Hi Marc,

On Mon, Feb 08, 2016 at 03:29:33PM +0000, Marc Zyngier wrote:
> On 08/02/16 09:11, Antoine Tenart wrote:
>
> > + gic: gic@f0100000 {
> > + compatible = "arm,gic-v3";
> > + reg = <0x0 0xf0200000 0x0 0x10000>, /* GIC Dist */
> > + <0x0 0xf0280000 0x0 0x200000>, /* GICR */
> > + <0x0 0xf0100000 0x0 0x2000>; /* GICC */
> > + interrupt-controller;
> > + #interrupt-cells = <3>;
> > + };
>
> Something is wrong here. Either you are missing GICH and GICV (assuming
> you have legacy support), or you have an extra GICC region (which
> doesn't make sense on its own).
>
> You're also missing the maintenance interrupt.
>
> Has Anapurna really built a GICv3 without an ITS?

I documented myself and Annapurna's GIC really doesn't have an ITS.

I'll add the missing regions.

Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature