Re: [PATCH] Input: colibri-vf50-ts: fix implicit declaration

From: Sudip Mukherjee
Date: Wed Feb 10 2016 - 05:04:35 EST


On Wed, Feb 10, 2016 at 10:54:45AM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 10, 2016 at 10:45 AM, Sudip Mukherjee
> <sudipm.mukherjee@xxxxxxxxx> wrote:
> > The build of m32r allmodconfig fails with the error:
> > drivers/input/touchscreen/colibri-vf50-ts.c:302:10: error: implicit
> > declaration of function 'of_property_read_u32'
> >
> > of_property_read_u32() is defined in linux/of.h which was not included.
> >
> > Fixes: 1261d013daea ("Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB")
>
> Actually I had sent the exact same patch to add this missing include,
> to apply before 1261d013daea, but it seems Dmitry only applied the
> second one.
>
> http://permalink.gmane.org/gmane.linux.kernel.gpio/14086

apart from m32r it also affects tilegx, s390, m68k allmodconfig.
I hope Dmitry applies any one from your or mine patch today.

regards
sudip