Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

[Mark Brown]

On Tue, Feb 09, 2016 at 03:21:54PM -0700, Lina Iyer wrote:
> On Tue, Feb 09 2016 at 06:13 -0700, Georgi Djakov wrote:

Please delete unneeded context from mails when replying.  Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.

> >+#define	SPM_REG_STS_1			0x10
> >+#define	SPM_REG_VCTL			0x14
> >+#define	SPM_REG_PMIC_DATA_0		0x28
> >+#define	SPM_REG_PMIC_DATA_1		0x2c
> >+#define	SPM_REG_RST			0x30

> These register offsets are SoC specific. You may want to follow the model
> of drivers/soc/qcom/spm.c in getting register offsets.

> While I see that you are only supporting APQ8064 with this patch, you
> probably would want to think a bit far ahead. To support any other QCOM
> SoC, you would need extensive changes.

This has already been applied.  It's not immediately clear to me that
changes simply to move the registers around would be more extensive than
just adding fields to the driver data, is it more than just that?

Attachment: signature.asc
Description: PGP signature