Re: [PATCH] gpio: TS-4800: remove useless bgpio_init flags

From: Julien Grossholtz
Date: Wed Feb 10 2016 - 12:17:33 EST


From: "Julien Grossholtz" <julien.grossholtz@xxxxxxxxxxxxxxxxxxxx>
To: "linus walleij" <linus.walleij@xxxxxxxxxx>
Cc: gnurou@xxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx>, kernel@xxxxxxxxxxxxxxxxxxxx, "Julien Grossholtz" <julien.grossholtz@xxxxxxxxxxxxxxxxxxxx>
Sent: Wednesday, February 10, 2016 11:58:34 AM
Subject: [PATCH] gpio: TS-4800: remove useless bgpio_init flags

No flags are required for bgpio_init in the TS-4800 gpio driver. This
patch set zero instead. The driver will have the same behaviour since
the | operator between the flags already resulted to zero.

There is a typo here, I will send it again.

Fixes: 5041e791440a ("gpio: add TS-4800 fpga GPIO support")

Signed-off-by: Julien Grossholtz <julien.grossholtz@xxxxxxxxxxxxxxxxxxxx>
---
drivers/gpio/gpio-ts4800.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
index c4908a4..9da79e4 100644
--- a/drivers/gpio/gpio-ts4800.c
+++ b/drivers/gpio/gpio-ts4800.c
@@ -48,8 +48,7 @@ static int ts4800_gpio_probe(struct platform_device *pdev)

retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
base_addr + OUTPUT_REG_OFFSET, NULL,
- base_addr + DIRECTION_REG_OFFSET, NULL,
- BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);
+ base_addr + DIRECTION_REG_OFFSET, NULL, 0);
if (retval) {
dev_err(&pdev->dev, "bgpio_init failed\n");
return retval;
--
2.5.0