Re: possible patch

From: Jonathan Corbet
Date: Wed Feb 10 2016 - 20:25:40 EST


On Wed, 10 Feb 2016 19:49:11 -0500
Justin Keller <justincompsci@xxxxxxxxx> wrote:

> I am new to submitting patches, so sorry if I am doing it wrong. My idea was
> to change line 147 in drivers/isdn/pcbit/callbacks.c from
> if (cbdata->data.setup.CallingPN == NULL) {
>
> to
>
> if (cbdata->data.setup.CallingPN == NULL ||
> sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {

If you want to patch the kernel, the best way to describe what you want to
do is to ... send a patch.

Before you do so, though:

- Please read the available documentation, including SubmittingPatches and
development-process/*

- Prepare a proper changelog saying *why* you want to make this change.
You are trying to change the ISDN subsystem, which is pretty static
these days; what current problem are you running into that makes you
think this change needs to be applied to the kernel?

Thanks,

jon